Date: Wed, 04 Nov 2020 13:09:59 +0100 From: "Kristof Provost" <kp@FreeBSD.org> To: "Gordon Bergling" <gbe@freebsd.org> Cc: "Mateusz Piotrowski" <0mp@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r367321 - head/sys/amd64/linux Message-ID: <BABF4769-6634-468C-BD00-D4169334C194@FreeBSD.org> In-Reply-To: <20201104104515.GA83813@lion.0xfce3.net> References: <202011041038.0A4AcPNn082013@repo.freebsd.org> <20201104104515.GA83813@lion.0xfce3.net>
index | next in thread | previous in thread | raw e-mail
On 4 Nov 2020, at 11:45, Gordon Bergling wrote: > Shouldn't such a commit be approved by someone? > The committer’s guide seems clear that doc committers may fix comments: https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/committer.types.html > doc committers may commit documentation changes to src files, such as > man pages, READMEs, fortune databases, calendar files, and comment > fixes without approval from a src committer, subject to the normal > care and tending of commits. Arguably minor spelling fixes are not worth confusing the blame output for, but this seems well within the established rules. > And why you just abandoned the differential [1]? > Probably because it timed out. The review had been pending since August. Arguably the differential link should have been included as well, but it’s hardly important in this case. I don’t think we have explicit policies about this. We probably should. Best regards, Kristofhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BABF4769-6634-468C-BD00-D4169334C194>