Date: Wed, 4 Aug 2010 15:21:00 +0200 From: Attilio Rao <attilio@freebsd.org> To: Robert Watson <rwatson@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, alfred@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_rwlock.c Message-ID: <AANLkTim4Y0Jyfz7XNcKkmCp1Zx-dHiyYWu9-HzK33FEU@mail.gmail.com> In-Reply-To: <AANLkTikpdCBOR3YonnEm0aWfpYuZFjd-k4e9jD%2BZ-HTy@mail.gmail.com> References: <200711142121.lAELLmo4018474@repoman.freebsd.org> <alpine.BSF.2.00.1008032350550.25854@fledge.watson.org> <AANLkTikpdCBOR3YonnEm0aWfpYuZFjd-k4e9jD%2BZ-HTy@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2010/8/4 Attilio Rao <attilio@freebsd.org>: > 2010/8/4 Robert Watson <rwatson@freebsd.org>: >> On Wed, 14 Nov 2007, Attilio Rao wrote: >> >>> attilio 2007-11-14 21:21:48 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/kern kern_rwlock.c >>> Log: >>> Remove a bogus KASSERT which will prevent rwlock to be acquired >>> recursively in exclusive mode with debugging kernels. >>> >>> Submitted by: kmacy >>> Approved by: jeff >>> >>> Revision Changes Path >>> 1.30 +0 -3 src/sys/kern/kern_rwlock.c >> >> Hi Attilio-- >> >> This bug seems also to affect the 6.x backport of rwlocks that Alfred did. >> Might either you or Alfred consider doing an MFC of this change? Without >> it, recursive write locks on rwlocks are broken with INVARIANTS enabled. > > Thanks for signaling this, I'll take care. r210844 may have fixed this. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTim4Y0Jyfz7XNcKkmCp1Zx-dHiyYWu9-HzK33FEU>