Date: Thu, 11 May 2000 11:32:43 -0700 From: Peter Wemm <peter@netplex.com.au> To: nate@yogotech.com (Nate Williams) Cc: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>, Greg Lehey <grog@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/vinum list.c Message-ID: <20000511183243.13AE51CD7@overcee.netplex.com.au> In-Reply-To: Message from Nate Williams <nate@yogotech.com> of "Thu, 11 May 2000 09:48:40 MDT." <200005111548.JAA17793@nomad.yogotech.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Nate Williams wrote:
> > <<On Thu, 11 May 2000 00:32:10 -0700 (PDT), Greg Lehey <grog@FreeBSD.org> s
aid:
> >
> > > Revision Changes Path
> > > 1.27 +12 -17 src/sbin/vinum/list.c
> >
> > > Revision Changes Path
> > > 1.34 +43 -40 src/sbin/vinum/vinum.8
> >
> > [...]
> >
> > Could you PLEASE batch your commits like everybody else?
>
> I actually prefer Greg's way of doing things. It's more email, but
> email is trivial to delete, and when you go look at things in the logs,
> it's much easier to figure out what's happening.
Likewise. When people ask me, I encourage them to make seperate discrete
commits where it makes sense to have accurate logs for the files affected by
the changes. Jumbo-commits where 500 files are affected with 500 different
changes are clearly suboptimal as all 500 change descriptions end up in 500
rcs files, instead of 1 change description in each of the 500 files.
The commit mail isn't as much of a problem compared to doing a 'cvs log'
and getting a small essay on the a commit that turns out to be a typo
correction in this particular file.
People should use their judgement to strike a balance between descriptive
logs describing an atomic change group over multiple files in a single
commit versus having each file getting an accurate standalone change log.
Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000511183243.13AE51CD7>