Date: Thu, 7 Mar 2002 22:09:32 -0500 From: Mike Barcroft <mike@FreeBSD.ORG> To: Garance A Drosihn <drosih@rpi.edu> Cc: "Andrey A. Chernov" <ache@nagual.pp.ru>, current@FreeBSD.ORG Subject: Re: <grp.h> fix is incomplete Message-ID: <20020307220932.G81803@espresso.q9media.com> In-Reply-To: <p05101510b8ad9996d976@[128.113.24.47]>; from drosih@rpi.edu on Thu, Mar 07, 2002 at 05:28:54PM -0500 References: <20020307182504.GA20764@nagual.pp.ru> <p05101510b8ad9996d976@[128.113.24.47]>
next in thread | previous in thread | raw e-mail | index | archive | help
Garance A Drosihn <drosih@rpi.edu> writes: > At 9:25 PM +0300 3/7/02, Andrey A. Chernov wrote: > ><grp.h> fix is incomplete because 'u_int32_t' is not defined > >(but must be) for standalone <grp.h>. Please add some includes > >for u_int32_t definition too, probably <sys/types.h> Perhaps subconsciously I was trying to keep making software include <sys/types.h> before <grp.h>. :) I just committed a fix. > As a minor side question, should we also have that defined as > uint32_t instead of u_int32_t ? Yes, usually. I just grabbed the copy from <sys/types.h>, which wasn't correct. uint32_t is more correct, but requires pollution from another header, so I used the __uint32_t variant. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020307220932.G81803>