Date: Sat, 5 Apr 2014 10:06:30 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Craig Rodrigues <rodrigc@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Peter Holm <peter@holm.cc> Subject: Re: ATF work Message-ID: <74A4FAAB-88B8-4226-949A-11AA8D99D662@gmail.com> In-Reply-To: <CAGHfRMBX7qeNZaWBUBYd0xejZvc8R=cfD64413tV5_3DfPh_zQ@mail.gmail.com> References: <20140402085349.GA61802@x2.osted.lan> <CAOtMX2gGn5NMpvSR0FF=z70cUCDn=vTQvVWo2mXk8t9UrNKzuA@mail.gmail.com> <CAG=rPVep6wrby4cej0fWSNtYrRhHLn5eOjDsNWWTYv0RpjDqUw@mail.gmail.com> <CAGHfRMBX7qeNZaWBUBYd0xejZvc8R=cfD64413tV5_3DfPh_zQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 2, 2014, at 11:47 AM, Garrett Cooper <yaneurabeya@gmail.com> = wrote: > On Wed, Apr 2, 2014 at 10:21 AM, Craig Rodrigues <rodrigc@freebsd.org> = wrote: >> On Wed, Apr 2, 2014 at 9:31 AM, Alan Somers <asomers@freebsd.org> = wrote: >>> On Wed, Apr 2, 2014 at 2:53 AM, Peter Holm <peter@holm.cc> wrote: >>>> I have uploaded a snapshot of the ATF work done for EMC Isilon, >>>> based primarily on Garrett Cooper's work. >>>>=20 >>>> = http://people.freebsd.org/~pho/FreeBSD-HEAD-ATF-Isilon-20140401.diff.xz >>>> + >>>> chmod +x /usr/src/lib/libc/tests/net/gen_ether_subr >>>=20 >>> Holy patch queue, Batman! There's fifty thousand lines of code in = here! >>=20 >>=20 >> When a patch is that big, it becomes very difficult to review. >>=20 >> You might want to consider forking a copy on github of the >> https://github.com/freebsd/freebsd repository and maintaining the = patch there >> until it is MFC'd: >>=20 >> https://help.github.com/articles/fork-a-repo >> https://help.github.com/articles/syncing-a-fork >>=20 >> It's not perfect but some of the web interface tools around the = github >> ecosystem make reviewing patches (and contributing updates) a bit = easier. >=20 > I was going to move master aside and make all of the ATF work into its > own separate branch again as my fork's master still contains little > tidbits of other fixes and hacks that I made to make things work on my > system(s). When I originally did this on my fork I was dealing with a > lot more branches (nowadays I mostly maintain my fork instead of > develop/port new code). I=92ve master on my fork reflects FreeBSD master. =93atf=94 now = reflects all of my ATF work, so if you diff master and atf you=92ll see = the relevant changes I=92ve done for ATF in the past. I=92ll update the = docs on the wiki to reflect this. Thanks! -Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?74A4FAAB-88B8-4226-949A-11AA8D99D662>