Date: Mon, 17 Nov 2008 10:30:38 +0900 (JST) From: haro@kgt.co.jp To: nwhitehorn@FreeBSD.org Cc: perforce@freebsd.org Subject: Re: PERFORCE change 153060 for review Message-ID: <20081117.103038.36764854.haro@kgt.co.jp> In-Reply-To: <200811162259.mAGMxvlw026231@repoman.freebsd.org> References: <200811162259.mAGMxvlw026231@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
From: Nathan Whitehorn <nwhitehorn at FreeBSD.org> Date: Sun, 16 Nov 2008 22:59:57 GMT ::http://perforce.freebsd.org/chv.cgi?CH=153060 :: ::Change 153060 by nwhitehorn@nwhitehorn_trantor on 2008/11/16 22:59:28 :: :: Fix interrupt-cells detection on Grackle. :: ::Affected files ... :: ::.. //depot/projects/ppc-g5/sys/powerpc/powermac/grackle.c#7 edit :: ::Differences ... :: ::==== //depot/projects/ppc-g5/sys/powerpc/powermac/grackle.c#7 (text+ko) ==== :: ::@@ -255,10 +255,12 @@ :: ofw_bus_setup_iinfo(node, &sc->sc_pci_iinfo, sizeof(cell_t)); :: :: /* We need the number of interrupt cells to read the imap */ ::- sc->sc_icells = 2; ::- if (OF_getprop(node, "interrupt-parent", &iparent,sizeof(iparent)) > 0) ::- OF_getprop(iparent,"#interrupt-cells",&sc->sc_icells, ::- sizeof(sc->sc_icells)); ::+ if (OF_getprop(node, "interrupt-parent", &iparent,sizeof(iparent)) <= 0) ::+ iparent = node; ::+ ::+ if (OF_getprop(iparent,"#interrupt-cells",&sc->sc_icells, ::+ sizeof(sc->sc_icells)) <= 0); ::+ sc->sc_icells = 1; Hello Nathan, A ";" after "if" statement does not seem correct to me. Hope this helps, Haro =----------------------------------------------------------------------- _ _ Munehiro (haro) Matsuda -|- /_\ |_|_| KGT Inc. /|\ |_| |_|_|
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081117.103038.36764854.haro>