Date: Mon, 22 Aug 2016 07:07:46 +0100 From: Robert Watson <rwatson@FreeBSD.org> To: "Andrey V. Elsukov" <ae@FreeBSD.org> Cc: Adrian Chadd <adrian@freebsd.org>, FreeBSD Net <freebsd-net@freebsd.org> Subject: Re: svn commit: r304313 - head/sys/net Message-ID: <92195690-7F54-4395-904F-109D122FFBB1@FreeBSD.org> In-Reply-To: <16924228-a88c-4d6e-0d51-fedcbec1594d@FreeBSD.org> References: <201608172021.u7HKLXJ4001584@repo.freebsd.org> <CAJ-Vmonu3ZSKZtZZMa68FAS9nDdiriE3iv81cjoW%2Bk3mHKO2=g@mail.gmail.com> <28FA9F29-FA29-4547-875D-0734DA120636@FreeBSD.org> <CAJ-VmokrNfoJNBoa7iUv0FhQyajAZz2BM7VzaGDu3KVUTmCWUA@mail.gmail.com> <16924228-a88c-4d6e-0d51-fedcbec1594d@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 Aug 2016, at 19:18, Andrey V. Elsukov <ae@FreeBSD.org> wrote: > On 21.08.16 20:33, Adrian Chadd wrote: >>> Does this make sense? >>=20 >> Right. Let me go and look into it a little more. I think we may want=20= >> to revert the change (which just landed to -11, so maybe revert that=20= >> too) so I can test both of them out for correctness. >>=20 >> Andrey, I'm sorry for suggesting we back it out, but I'd like to >> make sure we don't break networking on 11. :) Is that okay? I will >> look at this tonight/tomorrow. >=20 > Hi, >=20 > I already wanted to merge it into releneg/11.0. >=20 > ... > I think we can keep this in the release, but if you have an idea how = to > improve it - just do it and then do MFC. I tend to take the view that crashing is worse than not crashing, so we = should ensure something appears in releng/11.0 that is suitable to ship = in a release =E2=80=94 at the very least this patch. However, we do need = to be careful about packet reordering, as it can be extremely hard to = diagnose while leading to observable performance degradation, which is = clearly not the goal of enabling higher netisr thread counts. The change = required to do this properly should be extremely small, and it=E2=80=99s = worth getting it sorted out and merged for the release, if we can. Robert=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?92195690-7F54-4395-904F-109D122FFBB1>