Date: Sun, 11 Mar 2007 04:43:32 GMT From: Alex Kozlov<spam@rm-rf.kiev.ua> To: freebsd-gnats-submit@FreeBSD.org Subject: bin/110178: [patch] Fix handling of -n option in /sbin/mdmfs Message-ID: <200703110443.l2B4hWW5064140@www.freebsd.org> Resent-Message-ID: <200703110450.l2B4o4QX095381@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 110178
>Category: bin
>Synopsis: [patch] Fix handling of -n option in /sbin/mdmfs
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Mar 11 04:50:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator: Alex Kozlov
>Release: FreeBSD 6.2
>Organization:
private
>Environment:
>Description:
mdmfs describes -n option as 'rotational-positions' but in newfs it means 'do not create a .snap directory'
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
--- mdmfs.c
+++ mdmfs.c.new
@@ -127,7 +127,7 @@
}
while ((ch = getopt(argc, argv,
- "a:b:Cc:Dd:E:e:F:f:hi:LlMm:Nn:O:o:Pp:Ss:t:Uv:w:X")) != -1)
+ "a:b:Cc:Dd:E:e:F:f:hi:LlMm:NnO:o:Pp:Ss:t:Uv:w:X")) != -1)
switch (ch) {
case 'a':
argappend(&newfs_arg, "-a %s", optarg);
@@ -188,7 +188,7 @@
norun = true;
break;
case 'n':
- argappend(&newfs_arg, "-n %s", optarg);
+ argappend(&newfs_arg, "-n");
break;
case 'O':
argappend(&newfs_arg, "-o %s", optarg);
@@ -655,10 +655,10 @@
{
fprintf(stderr,
-"usage: %s [-DLlMNPSUX] [-a maxcontig] [-b block-size]\n"
+"usage: %s [-DLlMNnPSUX] [-a maxcontig] [-b block-size]\n"
"\t[-c blocks-per-cylinder-group][-d max-extent-size] [-E path-mdconfig]\n"
"\t[-e maxbpg] [-F file] [-f frag-size] [-i bytes] [-m percent-free]\n"
-"\t[-n rotational-positions] [-O optimization] [-o mount-options]\n"
+"\t[-O optimization] [-o mount-options]\n"
"\t[-p permissions] [-s size] [-v version] [-w user:group]\n"
"\tmd-device mount-point\n", getprogname());
exit(1);
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200703110443.l2B4hWW5064140>