Date: Tue, 20 Apr 2021 09:58:42 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: rgrimes@FreeBSD.org, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 686cf5468c4a - main - flex: Regen bootstrap files Message-ID: <202104201658.13KGwgnh071812@gndrsh.dnsmgr.net> In-Reply-To: <782d3c7b-fb30-d013-0426-692cc1ead645@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 21. 4. 20., Rodney W. Grimes wrote: > >> On 21. 4. 20., Rodney W. Grimes wrote: > >>>> The branch main has been updated by jkim: > >>>> > >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=686cf5468c4a85c2a6385cdbab2383900876a41d > >>>> > >>>> commit 686cf5468c4a85c2a6385cdbab2383900876a41d > >>>> Author: Jung-uk Kim <jkim@FreeBSD.org> > >>>> AuthorDate: 2021-04-19 18:20:51 +0000 > >>>> Commit: Jung-uk Kim <jkim@FreeBSD.org> > >>>> CommitDate: 2021-04-19 18:20:51 +0000 > >>>> > >>>> flex: Regen bootstrap files > >>>> > >>>> This also partially reverts r326025 (8a16b7a18f5d). I do not see any > >>>> point of adding SPDX tag in generated file. > >>> > >>> The SPDX identifies the copyright that follows it, so please put this back. > >> > >> It is a generated file. If you really think it is necessary, you need > >> to patch its source, i.e., contrib/flex/src/parse.y, and regen the file. > > > > Just because it is a generated file does not change the fact that > > its contents are copyrighted. Leaving the copyright out at best > > defaults to Bern convention, so the fact of the mater is the contents > > is copyrighted, and it is best to explicitly state that it is. > > Of course, it is copyrighted. My point was parse.y should have been > patched, not the generated file, if necessary. My complaint was ABOUT the change to parse.y that REMOVED the SPDX tag. This is NOT a generated file, it IS the right place to put the SPDX, immediatly before the copyright it refers to. > >> However, I don't see much sense in automatically adding BSD license in > >> every generated file in the first place. In fact, I think it should not > >> appear on generated file at all. It may say something along the line of > >> "generated by flex" instead but IANAL. > > > > Well, someone before you did see since in it, and hence put that SPDX in it. > > Let me put it in another way. Do we really want to tag contrib code? Now that is a seperate discussion, but again, someone did infact decide to do this in the past. I am simply asking that the tag be put back. > Jung-uk Kim -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202104201658.13KGwgnh071812>