Date: Tue, 9 Nov 2010 17:26:14 -0800 From: Garrett Cooper <gcooper@FreeBSD.org> To: Warner Losh <imp@freebsd.org> Cc: svn-src-head@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215070 - head/tools/tools/nanobsd Message-ID: <AANLkTinO%2BGmg-1s%2BBVirZ=i4mC=iD0GGEED4Fj-Y9_Xz@mail.gmail.com> In-Reply-To: <AANLkTikP64BJ_y2aT8y6Pv0hFQp9MFi2kzENC_%2Bg2Xot@mail.gmail.com> References: <201011100056.oAA0uimN067694@svn.freebsd.org> <AANLkTikP64BJ_y2aT8y6Pv0hFQp9MFi2kzENC_%2Bg2Xot@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 9, 2010 at 5:25 PM, Garrett Cooper <gcooper@freebsd.org> wrote: > On Tue, Nov 9, 2010 at 4:56 PM, Warner Losh <imp@freebsd.org> wrote: >> Author: imp >> Date: Wed Nov 10 00:56:44 2010 >> New Revision: 215070 >> URL: http://svn.freebsd.org/changeset/base/215070 >> >> Log: >> =A0Build make.conf when the world is not selected to build, but the >> =A0kernel is. >> >> =A0PR: =A0 =A0 =A0 =A0 =A0 151696 >> =A0Submitted by: lev@ >> >> Modified: >> =A0head/tools/tools/nanobsd/nanobsd.sh >> >> Modified: head/tools/tools/nanobsd/nanobsd.sh >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/tools/tools/nanobsd/nanobsd.sh Wed Nov 10 00:39:42 2010 =A0 =A0= =A0 =A0(r215069) >> +++ head/tools/tools/nanobsd/nanobsd.sh Wed Nov 10 00:56:44 2010 =A0 =A0= =A0 =A0(r215070) >> @@ -917,6 +917,9 @@ else >> =A0fi >> >> =A0if $do_kernel ; then >> + =A0 =A0 =A0 if ! $do_world ; then >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 make_conf_build >> + =A0 =A0 =A0 fi >> =A0 =A0 =A0 =A0build_kernel >> =A0else >> =A0 =A0 =A0 =A0pprint 2 "Skipping buildkernel (as instructed)" > > =A0 =A0Funny that it overwrites __MAKE_CONF, but not SRCCONF (seems like > the latter would infect a system more than the former *shrugs*); I > think I understand why it's not set in this script though, because > IIRC src.conf predates nanobsd. > =A0 =A0I set my core variables and features in src.conf so I think it'd > probably be better to block that out too. > =A0 =A0Should I provide a patch for this item? Sorry for the spam. I sent the email to the wrong list. -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinO%2BGmg-1s%2BBVirZ=i4mC=iD0GGEED4Fj-Y9_Xz>