Date: Wed, 19 Feb 2014 12:39:12 -0600 From: Stacey Son <sson@FreeBSD.org> To: Warner Losh <wlosh@bsdimp.com> Cc: "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org> Subject: Re: [RFC] Enable use of UserLocal Register (ULRI) if detected (patches) Message-ID: <7FA7DFD1-B1F1-400A-9107-8D8450B309A2@FreeBSD.org> In-Reply-To: <092B0786-EA73-44D0-81FC-DFB56B14D4D7@bsdimp.com> References: <D964DBB1-3727-4B8A-B4E3-50FD8A300818@FreeBSD.org> <092B0786-EA73-44D0-81FC-DFB56B14D4D7@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Feb 19, 2014, at 11:52 AM, Warner Losh <wlosh@bsdimp.com> wrote: > +/* Register numbers */ > +#define _V0 2 > +#define _A1 5 > +#define _T0 12 > +#define _RA 31 >=20 > We already have defines for these registers elsewhere. Any reason why = you chose not to use them? Also, is there any ABI difference to be = worried about? Hmm... I missed these in sys/mips/include/regnum.h for some reason. :) > The rest looks generally good, apart from references to git versions = that might be difficult to find in the future. Consider moving details = inline instead. That was really just a note to myself that I forgot to remove. I have refreshed the patch with these changes: http://people.freebsd.org/~sson/mips/ulri/ulri_kernel.diff >> The final patch is for qemu system-mode that adds support for the = ULRI: >>=20 >> http://people.freebsd.org/~sson/mips/ulri/ulri_qemu.diff >=20 > Can't say about these... Qemu, like a lot of MIPS hardware it seems, doesn't support the ULRI. = The above is a just quick hack to qemu to add support as a 'FYI'. I = should maybe clean it up and submit it to the qemu development list. -stacey.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7FA7DFD1-B1F1-400A-9107-8D8450B309A2>