Date: Thu, 7 Mar 2002 20:33:38 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: Garance A Drosihn <drosih@rpi.edu> Cc: Jake Burkholder <jake@locore.ca>, Robert Watson <rwatson@FreeBSD.ORG>, FreeBSD current users <current@FreeBSD.ORG> Subject: Re: Patch for critical_enter()/critical_exit() & interrupt assem Message-ID: <200203080433.g284XcV72256@apollo.backplane.com> References: <200203072143.g27LhaL97112@harmony.village.org> <Pine.NEB.3.96L.1020307171254.23264D-100000@fledge.watson.org> <20020307205844.C12044@locore.ca> <200203080304.g2834n571759@apollo.backplane.com> <p0510151eb8adde06e3ac@[128.113.24.47]>
next in thread | previous in thread | raw e-mail | index | archive | help
:Perhaps that part of the update could be considered "cosmetic", and
:thus be done as a separate update -- just so people can tell which
:lines are cosmetic changes and which ones are substantive. That is
:more work for you, but it makes it easier on reviewers, and it is
:certainly consistent with what developers are asked to do on other
:updates they make.
:
:You'll still probably have a debate on the "wonderfulness" of that
:cosmetic change, but at least it makes it easier for the major
:changes to looked at and commented on separately.
:
:--
:Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu
Ugh. I'd rather not. It would take a while to unwind the tabbing
from the deferred interrupts. i.e. I didn't just cleanup the syntax
in icu_vector.s, I also had to implement the same stuff I put
in apic_vector.s to support deferred interrupts.
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203080433.g284XcV72256>