Date: Thu, 02 Dec 1999 11:59:59 +0900 From: itojun@iijlab.net To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Cc: sumikawa@ebina.hitachi.co.jp Subject: Re: BROKEN port on FreeBSD-current Message-ID: <4441.944103599@coconut.itojun.org> In-Reply-To: sumikawa's message of Thu, 02 Dec 1999 11:53:33 JST. <19991202115333O.sumikawa@ebina.hitachi.co.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
>kris 1999/12/01 10:57:10 PST
> Modified files:
> japanese/magicpoint Makefile
> Log:
> Mark as BROKEN due to buffer overflow yielding setgid uucp. This also needs
> a portlint.
> Submitted by: Brock Tellier <btellier@usa.net>
I believe this to fix the problem. Could anyone check?
(already in magicpoint repository)
itojun
Index: uucplock.c
===================================================================
RCS file: /home/wide/itojun/cvsroot/mgp/kit/contrib/xmindpath/uucplock.c,v
retrieving revision 1.1
diff -c -r1.1 uucplock.c
*** uucplock.c 1998/08/23 04:50:17 1.1
--- uucplock.c 1999/12/02 02:57:21
***************
*** 55,61 ****
char tbuf[sizeof(_PATH_LOCKDIRNAME) + MAXNAMLEN];
off_t lseek();
! (void)sprintf(tbuf, _PATH_LOCKDIRNAME, ttyname);
fd = open(tbuf, O_RDWR|O_CREAT|O_EXCL, 0664);
if (fd < 0) {
/*
--- 55,61 ----
char tbuf[sizeof(_PATH_LOCKDIRNAME) + MAXNAMLEN];
off_t lseek();
! (void)snprintf(tbuf, sizeof(tbuf), _PATH_LOCKDIRNAME, ttyname);
fd = open(tbuf, O_RDWR|O_CREAT|O_EXCL, 0664);
if (fd < 0) {
/*
***************
*** 104,109 ****
{
char tbuf[sizeof(_PATH_LOCKDIRNAME) + MAXNAMLEN];
! (void)sprintf(tbuf, _PATH_LOCKDIRNAME, ttyname);
return(unlink(tbuf));
}
--- 104,109 ----
{
char tbuf[sizeof(_PATH_LOCKDIRNAME) + MAXNAMLEN];
! (void)snprintf(tbuf, sizeof(tbuf), _PATH_LOCKDIRNAME, ttyname);
return(unlink(tbuf));
}
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4441.944103599>