Date: Thu, 29 Jul 2010 23:25:30 +0200 From: Gabor Kovesdan <gabor@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, jilles@stack.nl Subject: Re: svn commit: r210578 - head/usr.bin/grep Message-ID: <4C51F1CA.6080702@FreeBSD.org> In-Reply-To: <20100729.142018.295937982770216853.imp@bsdimp.com> References: <201007290011.o6T0BE0l072516@svn.freebsd.org> <20100729122034.GA28899@stack.nl> <20100729.142018.295937982770216853.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Em 2010.07.29. 22:20, M. Warner Losh escreveu: > In message:<20100729122034.GA28899@stack.nl> > Jilles Tjoelker<jilles@stack.nl> writes: > : On Thu, Jul 29, 2010 at 12:11:14AM +0000, Gabor Kovesdan wrote: > :> Author: gabor > :> Date: Thu Jul 29 00:11:14 2010 > :> New Revision: 210578 > :> URL: http://svn.freebsd.org/changeset/base/210578 > : > :> Log: > :> - Some improvements on the exiting code, like replacing memcpy with > :> strlcpy/strcpy > : > : Hmm, I don't think this is an improvement :( > > I agree in this case. The changes don't actually improve the safety > of the code, but may make the code slower due to the need to recompute > the length... > Thanks to both of you for the comments. I'll talk to my mentor and revert those changes. Gabor
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C51F1CA.6080702>