Date: Tue, 3 Jul 2018 13:07:04 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335906 - head/sys/conf Message-ID: <6d02404f-a7bb-01c7-3775-7a0349e306be@FreeBSD.org> In-Reply-To: <201807031959.w63JxPA2069044@slippy.cwsent.com> References: <201807031959.w63JxPA2069044@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nrEq6SIfsbZGYTgfSZ5R3mSN64FvoLCIQ Content-Type: multipart/mixed; boundary="N66uQifSC1aSf1iMifRJdrqNP6RkoOJg1"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <6d02404f-a7bb-01c7-3775-7a0349e306be@FreeBSD.org> Subject: Re: svn commit: r335906 - head/sys/conf References: <201807031959.w63JxPA2069044@slippy.cwsent.com> In-Reply-To: <201807031959.w63JxPA2069044@slippy.cwsent.com> --N66uQifSC1aSf1iMifRJdrqNP6RkoOJg1 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/3/2018 12:59 PM, Cy Schubert wrote: > In message <201807031924.w63JOi5W051614@repo.freebsd.org>, Bryan=20 > Drewery writes > : >> Author: bdrewery >> Date: Tue Jul 3 19:24:44 2018 >> New Revision: 335906 >> URL: https://svnweb.freebsd.org/changeset/base/335906 >> >> Log: >> No need to make a copy to build genoffset_test.o >> >> Modified: >> head/sys/conf/kern.post.mk >> >> Modified: head/sys/conf/kern.post.mk >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> =3D >> --- head/sys/conf/kern.post.mk Tue Jul 3 19:09:46 2018 (r33590 >> 5) >> +++ head/sys/conf/kern.post.mk Tue Jul 3 19:24:44 2018 (r33590 >> 6) >> @@ -191,14 +191,12 @@ offset.inc: $S/kern/genoffset.sh genoffset.o >> genoffset.o: $S/kern/genoffset.c >> ${CC} -c ${CFLAGS:N-flto:N-fno-common} $S/kern/genoffset.c >> =20 >> -genoffset_test.c: $S/kern/genoffset.c >> - cp $S/kern/genoffset.c genoffset_test.c >> - >> # genoffset_test.o is not actually used for anything - the point of c= ompilin >> g it >> # is to exercise the CTASSERT that checks that the offsets in the off= set.inc >> # _lite struct(s) match those in the original(s).=20 >> -genoffset_test.o: genoffset_test.c offset.inc >> - ${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST genoffset_test.= c >> +genoffset_test.o: $S/kern/genoffset.c offset.inc >> + ${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST ${.ALLSRC:M*.c}= \ >> + -o ${.TARGET} >=20 > -o with -c in the previous line will cause an error. -o and -c are fine together. The problem is .ALLSRC duplicating sources from the dependencies read from .depend.genoffset_test.o file. Workaround in r335908. >=20 >> =20 >> assym.inc: $S/kern/genassym.sh genassym.o genoffset_test.o >> NM=3D'${NM}' NMFLAGS=3D'${NMFLAGS}' sh $S/kern/genassym.sh genassym.= o > ${. >> TARGET} >> >=20 >=20 --=20 Regards, Bryan Drewery --N66uQifSC1aSf1iMifRJdrqNP6RkoOJg1-- --nrEq6SIfsbZGYTgfSZ5R3mSN64FvoLCIQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEbBAEBAgAGBQJbO9doAAoJEDXXcbtuRpfPquUH92aRqCMwTG0ax2Hu06Fql/lX Kn3iDz/KaCDnuXmnHJ5sgzbGSgevoqgZQnDJp9lrEvroNbsqsXNfFKw2f19ZOf1f g00nafksrxXCIsbK3IF/uwXiseuEaq7yH4TAXg7Yohy2TtnVgh2bxi2tNrkYgnPO lDCTMlbe2DfnsF0ygu6EcaZ1IgQGEbWMS5J4Jue6GoKr8pWZEZgT6kOuUiUVra8D wRWADypq+jw4ADJmgF8u1YVjrdK9q6Yxx3FphnnGi21Rz+RQoSimuEyQ/vUBsCyI DMa0hWxsNbNLx84T60pPHpfV3BJfCYWZHyxMdwLxX5BOEbQphBAzdxYT9Ia9nQ== =ZtE0 -----END PGP SIGNATURE----- --nrEq6SIfsbZGYTgfSZ5R3mSN64FvoLCIQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6d02404f-a7bb-01c7-3775-7a0349e306be>