Date: Tue, 23 Apr 2024 12:02:36 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Lexi Winter <lexi@le-fay.org> Cc: Ed Maste <emaste@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, imp@freebsd.org Subject: Re: git: 67783db661f8 - main - CONTRIBUTING: request only one submission type per change Message-ID: <ZigFzAIs7eZQ3DMW@cell.glebi.us> In-Reply-To: <ZiF0PH5yWJlbaFo8@ilythia.eden.le-fay.org> References: <202404181915.43IJFEoG020480@gitrepo.freebsd.org> <ZiF0PH5yWJlbaFo8@ilythia.eden.le-fay.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Lexi, On Thu, Apr 18, 2024 at 08:27:56PM +0100, Lexi Winter wrote: L> as a non-committer src contributor, i've discussed this with imp@ quite L> a bit and i think this should be phrased more strongly in favour of L> using GitHub for commits. L> L> the current situation is that Phabricator is useless for non-committers L> because 1) you have to know who can review your commit, and 2) once your L> commit is reviewed, someone has to commit it, and Phabricator doesn't L> address this. The 1) is actually not as bad. Phabricator has subscribtion hooks, and many committers have rules installed to get notifications of new reviews that touch certain paths of code. The problem 2), IMHO, equally applies to github and Phabricator. L> i think it might make more sense to suggest that people submit all L> patches via either GitHub or Bugzilla, and only use Phabricator if L> specifically asked to. I don't agree here. Looks like we should address those phabricator submissions that go unnoticed due to lack of maintainers of a code. I don't think submitting same patch to github will improve visibility. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZigFzAIs7eZQ3DMW>