Date: Thu, 23 Oct 2008 01:02:16 +0400 From: Andrey Chernov <ache@nagual.pp.ru> To: Konstantin Belousov <kib@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r184177 - head/lib/libc/gen Message-ID: <20081022210216.GA67445@nagual.pp.ru> In-Reply-To: <200810221955.m9MJtCT9037516@svn.freebsd.org> References: <200810221955.m9MJtCT9037516@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 22, 2008 at 07:55:12PM +0000, Konstantin Belousov wrote: > Author: kib > Date: Wed Oct 22 19:55:12 2008 > New Revision: 184177 > URL: http://svn.freebsd.org/changeset/base/184177 > > Log: > Remove doubtful structure definition with variable array members. > I believe this is not a valid C99 construct. Use directly calculated > offsets into the supplied buffer, using specified members length, > to fill appropriate structure. > > Either use sysctl, or copy the value of the UNAME_x environment > variable, instead of unconditionally doing sysctl, and then > overriding a returned value with user-specified one. > > Noted and tested by: rdivacky Unfortunately on i386 this change cause segfaults in many programs at once (even in make(1)) -- http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081022210216.GA67445>