Date: Tue, 1 Aug 2006 10:54:25 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: infofarmer@FreeBSD.org Cc: cvs-ports@FreeBSD.org, sat@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.linux-rpm.mk Message-ID: <20060801105425.779a4b26@Magellan.Leidinger.net> In-Reply-To: <cb5206420607310838h7187c289kdc80a8c8c311e9b9@mail.gmail.com> References: <200607302234.k6UMYUuq018943@repoman.freebsd.org> <20060731121024.3d6478b4@Magellan.Leidinger.net> <cb5206420607310838h7187c289kdc80a8c8c311e9b9@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting "Andrew Pantyukhin" <sat@FreeBSD.org> (Mon, 31 Jul 2006 19:38:33 +0400): > On 7/31/06, Alexander Leidinger <Alexander@leidinger.net> wrote: > > Quoting Andrew Pantyukhin <sat@FreeBSD.org> (Sun, 30 Jul 2006 22:34:30 +0000 (UTC)): > > > > > sat 2006-07-30 22:34:30 UTC > > > > > > FreeBSD ports repository > > > > > > Modified files: > > > Mk bsd.linux-rpm.mk > > > Log: > > > - Only set default m_s_subdir if master_sites was undefined > > > > Would you please describe which problem this commit tries to solve > > (perhaps as a forced commit)? > > Fedora has a rather unique MSS scheme (related to its versioning) > and applying the scheme to another MS does not seem very > practical. In practice, a more relevant default value might be > attempted to be set after bsd.linux-rpm.mk. The default linux base is FC4, and most linux-infrastructure ports are from FC4 too. Those ports are the only ports which use this stuff ATM. So ATM it's very practical. > > I'm not sure if we have some ports which set MS but depend on the auto > > assigning of MSS, but I would not be surprised if we have such ports. > > Did you check for such ports? > > Sure. There are 29 USE_LINUX_RPM ports, only three set MS, > two of them don't need MSS at all and the third one would rather > MSS was not touched by linux-rpm.mk. Which port is the third one? > I'm sorry I committed this without prior discussion, but I tried to > make sure the change was not desctructive and as simple as it > gets. The mk is used by a lot of ports, so any bug may harm a lot of ports. I don't object if you want to join us at emulation@ (actually I would be very happy to see more contributors), but a review request for changes with a high impact ratio (in case of a bug) would be very nice next time. Bye, Alexander. -- Sometimes one should just look at things and think about things without doing things. -- Calvin http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060801105425.779a4b26>