Date: Thu, 8 Jan 2009 19:43:19 +0100 From: Remko Lodder <remko@elvandar.org> To: Hans Petter Selasky <hselasky@FreeBSD.org> Cc: perforce@freebsd.org, "M. Warner Losh" <imp@bsdimp.com> Subject: Re: PERFORCE change 155748 for review Message-ID: <61E32407-BF64-47D0-89E9-EB0B9EB22B91@elvandar.org> In-Reply-To: <200901081839.27124.hselasky@freebsd.org> References: <200901071009.n07A9jrs056953@repoman.freebsd.org> <20090108.102311.1541746851.imp@bsdimp.com> <200901081839.27124.hselasky@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 8, 2009, at 6:39 PM, Hans Petter Selasky wrote: > On Thursday 08 January 2009, M. Warner Losh wrote: >> In message: <200901071009.n07A9jrs056953@repoman.freebsd.org> >> >> Hans Petter Selasky <hselasky@freebsd.org> writes: >> : http://perforce.freebsd.org/chv.cgi?CH=155748 >> : >> : Change 155748 by hselasky@hselasky_laptop001 on 2009/01/07 10:09:35 >> : >> : >> : Umass module quirk from Alexander Best >> : to support Meizu Electronics MiniPlayer. >> : >> : Affected files ... >> : >> : .. //depot/projects/usb/src/sys/dev/usb/usbdevs#35 edit >> : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21 >> edit >> : .. //depot/projects/usb/src/sys/dev/usb2/include/ >> usb2_devtable.h#21 edit >> : .. //depot/projects/usb/src/sys/dev/usb2/storage/umass2.c#20 edit >> : >> : ==== //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21 >> : (text+ko) ==== ==== >> : //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#21 >> : (text+ko) ==== >> >> Why are these generated files committed to the tree? We did a lot of >> work to make usbdevs generated files not need to be committed to the >> tree and this breaks that... >> >> Warner > > Because they are not automatically generated any more. > > --HPS Hmm, I liked the idea of only needing to do something marginally to add something. If files are no longer generated automatically and I need to do more, I'll look for other low hanging fruit. In short: can you restore automatic regenerating behaviour? -- /"\ Best regards, | remko@FreeBSD.org \ / Remko Lodder | remko@EFnet X http://www.evilcoder.org/ | / \ ASCII Ribbon Campaign | Against HTML Mail and News
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?61E32407-BF64-47D0-89E9-EB0B9EB22B91>