Date: Sun, 20 Jun 2010 12:21:47 +1000 From: Lawrence Stewart <lstewart@freebsd.org> To: Rui Paulo <rpaulo@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r209158 - in head/contrib/wpa: hostapd hostapd/doc src/common src/crypto src/drivers src/eap_common src/eap_peer src/eap_server src/eapol_supp src/hlr_auc_gw src/l2_packet src/radius sr... Message-ID: <4C1D7B3B.8080609@freebsd.org> In-Reply-To: <E5DAEB1B-39C5-4F3C-88EC-DD49DBDF4D02@freebsd.org> References: <201006141537.o5EFbnTD093866@svn.freebsd.org> <4C1C3162.60300@freebsd.org> <D26C2964-98C4-482D-9071-466679E1E024@FreeBSD.org> <4C1D000C.8090807@freebsd.org> <E5DAEB1B-39C5-4F3C-88EC-DD49DBDF4D02@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/20/10 05:22, Rui Paulo wrote: > Lawrence, > I don't see the point in enabling svn:keywords in vendor code. It's actually a good thing that radiotap.h doesn't get expanded. Rui, please accept my apologies. I *actually* understand the problem now as opposed to that lame 3am attempt earlier this morning. I was confused why vendor code would have $FreeBSD$ in it at all (thinking it was somehow a special case) which is why I thought you needed to set the keywords on the two radiotap.h files. I realise now that it's perfectly legit as it is and is that way because Sam pushed that code with the expanded keyword upstream and now we're importing it back in. The real problem is that Hg doesn't know about the svn autoprops during the conversion and my Hg keyword expansion config for $FreeBSD$ doesn't know to ignore $FreeBSD$ in contrib/*. Mea culpa and very sorry for lowering the SNR. Cheers, Lawrence
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C1D7B3B.8080609>