Date: Tue, 3 Sep 2019 11:45:23 +0000 From: Brooks Davis <brooks@freebsd.org> To: Shawn Webb <shawn.webb@hardenedbsd.org> Cc: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys Message-ID: <20190903114523.GA68094@spindle.one-eyed-alien.net> In-Reply-To: <20190903113505.ckbx5i34onmin557@mutt-hbsd> References: <201909030416.x834GVwk004191@repo.freebsd.org> <20190903113505.ckbx5i34onmin557@mutt-hbsd>
next in thread | previous in thread | raw e-mail | index | archive | help
--IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 03, 2019 at 07:35:05AM -0400, Shawn Webb wrote: > Hey Mateusz, >=20 > On Tue, Sep 03, 2019 at 04:16:31AM +0000, Mateusz Guzik wrote: > > Author: mjg > > Date: Tue Sep 3 04:16:30 2019 > > New Revision: 351729 > > URL: https://svnweb.freebsd.org/changeset/base/351729 > >=20 > > Log: > > Add sysctlbyname system call > > =20 > > Previously userspace would issue one syscall to resolve the sysctl an= d then > > another one to actually use it. Do it all in one trip. > > =20 > > Fallback is provided in case newer libc happens to be running on an o= lder > > kernel. > > =20 > > Submitted by: Pawel Biernacki > > Reported by: kib, brooks > > Differential Revision: https://reviews.freebsd.org/D17282 > >=20 > > Modified: > ... snip ... > > head/sys/sys/param.h >=20 > ... snip ... >=20 > >=20 > > Modified: head/sys/sys/param.h > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/sys/param.h Mon Sep 2 21:57:57 2019 (r351728) > > +++ head/sys/sys/param.h Tue Sep 3 04:16:30 2019 (r351729) > > @@ -60,7 +60,7 @@ > > * in the range 5 to 9. > > */ > > #undef __FreeBSD_version > > -#define __FreeBSD_version 1300044 /* Master, propagated to newvers */ > > +#define __FreeBSD_version 1300045 /* Master, propagated to newvers */ >=20 > To an outsider, it seems that __FreeBSD_version tends to be bumped in > a separate commit. Am I remembering that right? It should be bumped in the same commit, but people forget or the bump they have in their review turns into a no-op because someone else does a bump in the interim (the latter has bit me several times). =20 -- Brooks --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJdblJSAAoJEKzQXbSebgfAHnAH/iTwzH5oytRHj7/4d3ztHjKH SfW9Y7YTrAK0rIbDADiB3tU0BPjGGx6ogUMm/Cjly2NDEhVu+b4roVF+UOanp3X0 OoTwExFm+igBtctveuzseAozqnx3wVUDEvjvyzq0XtfPgC/Wnij84WK/rtyybdeg tHunIH1TDbWHZnRLhR+mZrqXcraqYFej72aSa/nY+kjBkALENuynGS/ix636/QTe HRpveQZARezpr9B/aObmb7/SajqQZq9k5jZEsRd5FoE2ECaYe8ys+EVioP7Wo05W jJ4k8Dn/yAHahTabaKctQyb4Wej7ynOjsC/aOXeXS4SYzVor89zc/qZ0jEYutvI= =97Wz -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190903114523.GA68094>