Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Feb 2001 20:38:57 -0800
From:      Peter Wemm <peter@netplex.com.au>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        Matt Dillon <dillon@earth.backplane.com>, Tor.Egge@fast.no, eischen@vigrid.com, current@FreeBSD.ORG
Subject:   Re: HEADS UP: installworld gotchas 
Message-ID:  <200102120438.f1C4cvU45235@mobile.wemm.org>
In-Reply-To: <Pine.BSF.4.21.0102121509160.2928-100000@besplex.bde.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote:
> On Sun, 11 Feb 2001, Peter Wemm wrote:
> 
> > I cant help but wonder why on earth we didn't have it like this from the
> > start:
> > 
> > Index: include/stdio.h
> > ===================================================================
> > RCS file: /home/ncvs/src/include/stdio.h,v
> > retrieving revision 1.26
> > diff -u -r1.26 stdio.h
> > --- include/stdio.h	2001/02/11 22:04:18	1.26
> > +++ include/stdio.h	2001/02/12 01:27:16
> > @@ -132,6 +132,9 @@
> >  
> >  __BEGIN_DECLS
> >  extern FILE __sF[];
> > +extern FILE *__stdin;
> > +extern FILE *__stdout;
> > +extern FILE *__stderr;
> >  __END_DECLS
> 
> Once upon a time, people counted every instruction in getchar(), etc.,
> and programmed it carefully to unnecessary indirections, not to mention
> function calls and locks.

And, because it breaks global declarations like this:
FILE *buffer = stdout;	/* default buffer file is stdout */

I have fixed this to avoid the indirection, and am doing a buildworld
to check it.  It should be the same speed as before, but is still immune
to the FILE size changes.

Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200102120438.f1C4cvU45235>