Date: Thu, 29 Jul 2010 02:34:29 +0200 From: Joerg Sonnenberger <joerg@britannica.bec.de> To: svn-src-all@freebsd.org Subject: Re: svn commit: r210578 - head/usr.bin/grep Message-ID: <20100729003429.GA6430@britannica.bec.de> In-Reply-To: <201007290011.o6T0BE0l072516@svn.freebsd.org> References: <201007290011.o6T0BE0l072516@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 29, 2010 at 12:11:14AM +0000, Gabor Kovesdan wrote: > - Some improvements on the exiting code, like replacing memcpy with > strlcpy/strcpy Why is this an improvement? At least for non-trivial sizes, it is quite likely to be a regression. Especially using strlcpy as replacement for memcpy+\0 is bogus. Joerg
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100729003429.GA6430>