Date: Tue, 29 Nov 2011 22:35:58 +0600 From: Max Khon <fjoe@FreeBSD.org> To: Alexander Kabaev <kabaev@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228124 - in head: share/mk sys/conf Message-ID: <CADe0-4=C=50jzkH4Tvwx%2Bq3bUxpBQ0tLNGvATu7CEK59Kk6bxQ@mail.gmail.com> In-Reply-To: <20111129090043.0ac7fa56@kan.dyndns.org> References: <201111290838.pAT8clOa031710@svn.freebsd.org> <20111129090043.0ac7fa56@kan.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander, On Tue, Nov 29, 2011 at 9:00 PM, Alexander Kabaev <kabaev@gmail.com> wrote: > Author: fjoe > > Date: Tue Nov 29 08:38:47 2011 > > New Revision: 228124 > > URL: http://svn.freebsd.org/changeset/base/228124 > > > > Log: > > Conditionalize ctfconvert/ctfmerge runs on make level (.if/.endif) > > instead of executing a shell on every object or executable/library > > file. > > This shaves off more than 30,000 shell invocations during > > buildworld. > > Have you looked as to _why_ it was done through shell invocation in the > first place before removing it? You now have broken CTF support in > cases where WITH_CTF is set not on make command line or in environment, > but say in each individual Makefile. I tested all the use-cases mentioned in the original commit but it looks like I specified the location of modified share/mk incorrectly when I did WITH_CTF userland tests. Should be fixed now. Sorry for the breakage. Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADe0-4=C=50jzkH4Tvwx%2Bq3bUxpBQ0tLNGvATu7CEK59Kk6bxQ>