Date: Sat, 07 Apr 2001 12:24:14 +0100 From: Brian Somers <brian@Awfulhak.org> To: Bruce Evans <bde@zeta.org.au> Cc: freebsd-bugs@FreeBSD.org, brian@Awfulhak.org, mckusick@FreeBSD.org Subject: Re: bin/26057: [PATCH] Minor ps(1) fixes Message-ID: <200104071124.f37BOEl55762@hak.lan.Awfulhak.org> In-Reply-To: Message from Bruce Evans <bde@zeta.org.au> of "Sat, 07 Apr 2001 01:20:03 PDT." <200104070820.f378K3R53066@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > ps.c part committed by brian (1.37 of bin/ps/ps.c). I'll update the
> > man page later today.
>
> The committed fix is half-baked at best. It does't even remove the
> session keyword like the first version of the PR does.
>
> Kirk also removed the tsess pointer and keyword from everywhere except
> ps.1, but the PR doesn't mention it. The log message for rev.1.25 of
> keyword.c says the following about the removal:
>
> kernel/user interface, specifically rusage and rtprio. It no
> longer contains proc, session, pcred, ucred, procsig, vmspace,
> pstats, mtx, sigiolst, klist, callout, pasleep, or mdproc. If
> any of these changed in size, ps, w, fstat, gcore, systat, and
> top would all stop working. The new structure has over 200 bytes
>
> This is incorrect for "session" in ps at least. ps would not have
> stopped working if sizeof(struct session) changed, since it just
> printed the session pointer.
I've now updated the documentation. Do you and Kirk agree that sess
and tsess should come back ?
> Bruce
--
Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org>
<http://www.Awfulhak.org>; <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200104071124.f37BOEl55762>