Date: Wed, 25 Feb 2015 22:17:18 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, John Baldwin <jhb@freebsd.org>, Rui Paulo <rpaulo@me.com>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r278914 - in head/sys: kern sys Message-ID: <20150225221718.GA70971@FreeBSD.org> In-Reply-To: <CAPyFy2CX-Qeq9-7TRrLw7F1sugYC6TCEPWYoXzbec-SbGN9Yzg@mail.gmail.com> References: <201502171932.t1HJWCWk092408@svn.freebsd.org> <CC670851-4CAE-4C61-A4DE-F5E96A8B773C@me.com> <20150225134004.GA84927@FreeBSD.org> <5199092.b33a1iaAip@ralph.baldwin.cx> <CAPyFy2CX-Qeq9-7TRrLw7F1sugYC6TCEPWYoXzbec-SbGN9Yzg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 25, 2015 at 05:04:07PM -0500, Ed Maste wrote: > On 25 February 2015 at 14:47, John Baldwin <jhb@freebsd.org> wrote: > > On Wednesday, February 25, 2015 01:40:04 PM Alexey Dokuchaev wrote: > >> > >> In r278673 I used full URL to D1801, but it was not closed for some > >> reason. Could it be that rS (src repository) entries auto-closed when > >> committed by src-folks only? > > > > It seems like it might not close a differential that hasn't been accepted > > yet [...] That would make sense, but I've certainly had committed proposed patch after D1801 was accepted (twice). > I think this is an intermittent failure in Phabricator. I expect it to > close upon commit regardless of the state of the review. Assuming (for now) that it is some weird failure, I've manually closed D1801 and provided correct auto-close-like message (citing SVN revision and author links). On a related note: while searching for proper auto-close message, I've found that many differentials are closed without marking SVN revision as such, so it does not link to it directly. This is not nice; we should make sure that these "dots are connected". ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150225221718.GA70971>