Date: Wed, 10 Jan 2018 17:14:44 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Warner Losh <imp@freebsd.org> Subject: Re: svn commit: r327767 - in head/sys: conf i386/bios i386/conf i386/isa Message-ID: <20180110171444.GA85022@FreeBSD.org> In-Reply-To: <CANCZdfqmNiaBtCduuz0Z8VzCUe-kndbSdg5KEp1tKwa1VeRQvQ@mail.gmail.com> References: <201801101459.w0AExJWM055025@repo.freebsd.org> <201801101631.w0AGVAEV032087@pdx.rh.CN85.dnsmgr.net> <CANCZdfrs-xgeyaQbKArXwYX-TYOrxqG1-gYuQRs5wP3--r3%2BtA@mail.gmail.com> <20180110165821.GA69465@FreeBSD.org> <CANCZdfqmNiaBtCduuz0Z8VzCUe-kndbSdg5KEp1tKwa1VeRQvQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 10, 2018 at 10:01:41AM -0700, Warner Losh wrote: > On Wed, Jan 10, 2018 at 9:58 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > > On Wed, Jan 10, 2018 at 09:48:05AM -0700, Warner Losh wrote: > > > On Wed, Jan 10, 2018 at 9:31 AM, Rodney W. Grimes wrote: > > > > > New Revision: 327767 > > > > > URL: https://svnweb.freebsd.org/changeset/base/327767 > > > > > > > > > > Log: > > > > > Retire pmtimer driver. Move time fixing into apm driver. Move > > > > > Iwasaki-san's copyright over. Remove FIXME code that couldn't > > possibly > > > > > work. Call tc_settime() with our estimate of the delta we've been > > > > > alseep (the one we print) to adjust the time. Not sure what to do > > > > > about callouts, so keep the small #ifdef in place there. > > > > > > > > > > Differential Revision: https://reviews.freebsd.org/D13823 > > > > > > > > RELNOTES: ? > > > > Reason I ask is this effects custom kernel config file(s) > > > > > > Don't know. We don't normally document every kernel config file changes > > > that's required. > > > > Well, `pmtimer' is a bit special. It is required in the kernel config in > > order to preserve time counting during suspend (not sure about amd64, but > > at least on i386, "device pmtimer" is required to be in kernel config for > > timekeeping while sleeping). > > It's only required for APM. ACPI it's a nop. > > And it didn't (until I believe that I fixed it) even adjust the time for > APM. On APM it just prints how long the sleep was. Not sure of now, but at least back in 2013 pmtimer was required on my i386 ACPI-ish laptop (it is still required now, but I just don't run -CURRENT): https://lists.freebsd.org/pipermail/svn-src-all/2013-May/069020.html ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180110171444.GA85022>