Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 Mar 2002 21:46:16 -0500
From:      Mike Barcroft <mike@FreeBSD.org>
To:        Dag-Erling Smorgrav <des@ofug.org>
Cc:        "J. Mallett" <jmallett@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.bin/uudecode uudecode.c
Message-ID:  <20020318214616.K56122@espresso.q9media.com>
In-Reply-To: <xzpn0x5ffnf.fsf@flood.ping.uio.no>; from des@ofug.org on Tue, Mar 19, 2002 at 03:35:48AM %2B0100
References:  <200203190205.g2J25Ru35647@freefall.freebsd.org> <xzpn0x5ffnf.fsf@flood.ping.uio.no>

next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smorgrav <des@ofug.org> writes:
> "J. Mallett" <jmallett@FreeBSD.org> writes:
> >   Reviewed by:    mike
> >   Approved by:    mike
> 
> You don't need both when it's the same person.

Have you changed your mind since July?

: Message-ID: <xzp4rs8mtpe.fsf@flood.ping.uio.no>
:
: "David O'Brien" <obrien@FreeBSD.org> writes:
: > On Fri, Jul 20, 2001 at 12:05:55AM +0200, Dag-Erling Smorgrav wrote:
: > > Mike Barcroft <mike@FreeBSD.org> writes:
: > > > Approved by:	des
: > > also reviewed by same.
: > The assumption is if you approved something, you reviewed it.
: 
: Not necessarily - I sometimes approve commits to code I maintain on
: the basis of trust in the requesting committer's abilities.  In this
: particular case, however, Mike is my mentee, so I review every patch
: he commits to pieces before I approve it.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020318214616.K56122>