Date: Tue, 26 Nov 2013 18:25:23 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Steven Hartland <killing@multiplay.co.uk>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r258632 - in head: cddl/contrib/opensolaris/cmd/ztest cddl/contrib/opensolaris/lib/libzpool/common/sys sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys... Message-ID: <5294CB73.7030704@FreeBSD.org> In-Reply-To: <54A7475886594221ABD007A86649441D@multiplay.co.uk> References: <201311260957.rAQ9vF6d004168@svn.freebsd.org> <AEC0945BC2474F7A835A8F4AFB988F0F@multiplay.co.uk> <5294A0CD.8030000@FreeBSD.org> <54A7475886594221ABD007A86649441D@multiplay.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
on 26/11/2013 18:18 Steven Hartland said the following: > ----- Original Message ----- From: "Andriy Gapon" <avg@FreeBSD.org> > > >> on 26/11/2013 14:34 Steven Hartland said the following: >>> Can I ask why choose priority now for TRIM, does this not change the flow of >>> free requests quite significantly? >> >> Sorry, I couldn't grok the question... >> Also, please take into account that I know nothing about TRIM nor TRIM + ZFS. >> >> BTW, I appreciate the review but a timely review[*] would be appreciated even >> more :-) > > Erm did I miss something, this only got commited a few hours ago which is > the first I knew about it. Did you ask for reviews somewhere I'm not aware of? Did you trim too much of my reply? There was a "footnote" with a reference. >>> Also as we have rotational information available should we apply >>> the following change which makes the active queue timestamp sorted >>> instead of offset sorted? >>> >>> An AVL as a FIFO queue seems like quite an expensive option. >> >> I've just merged the upstream change, perhaps badly. >> Any improvement are appreciated. > > Will look in more depth at this one as it touches the mirror code I commited > recently. Thank you! -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5294CB73.7030704>