Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 5 Nov 2010 14:59:58 -0400
From:      Mark Johnston <markjdb@gmail.com>
To:        Nick Hibma <nick@van-laarhoven.org>
Cc:        freebsd-current@freebsd.org
Subject:   Re: [Patch] libfetch - closing the cached FTP connection
Message-ID:  <20101105185958.GC1437@mark-laptop-bsd.mark-home>
In-Reply-To: <08D6E625-5BE9-4121-A0D8-8B5BDA20A813@van-laarhoven.org>
References:  <20101024231119.GA2123@mark-laptop-bsd.mark-home> <20101024231642.GB2123@mark-laptop-bsd.mark-home> <A72115A0-00E4-4FDB-974C-E06D31116794@van-laarhoven.org> <20101105152009.GB1437@mark-laptop-bsd.mark-home> <08D6E625-5BE9-4121-A0D8-8B5BDA20A813@van-laarhoven.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Fri, Nov 05, 2010 at 07:27:43PM +0100, Nick Hibma wrote:
> > I think using fcntl is nicer than having a "close the cached connection"
> > function, but I don't think I can get around this problem without
> > changing something in libfetch.
> 
> I think libfetch should set the Close-On-Exec flag. It's wrong to have these files propagate to children.
> 
> Nick_______________________________________________

Oh I see, I thought you were talking about changing pkg_add alone. I'll
post an alternative patch to the PR I opened (bin/151866).

Thanks,
-Mark



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101105185958.GC1437>