Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Mar 2003 03:02:18 -0500 (EST)
From:      Jeff Roberson <jroberson@chesapeake.net>
To:        Tor Egge <tegge@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/conf NOTES files options src/sys/kern      vfs_bio.c src/sys/ufs/ffs ffs_rawread.c ffs_vnops.c
Message-ID:  <20030327025926.K64602-100000@mail.chesapeake.net>
In-Reply-To: <200303262340.h2QNegJg065498@repoman.freebsd.org>

index | next in thread | previous in thread | raw e-mail

On Wed, 26 Mar 2003, Tor Egge wrote:

> tegge       2003/03/26 15:40:42 PST
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/conf             NOTES files options
>     sys/kern             vfs_bio.c
>     sys/ufs/ffs          ffs_vnops.c
>   Added files:
>     sys/ufs/ffs          ffs_rawread.c
>   Log:
>   Add support for reading directly from file to userland buffer when the
>   O_DIRECT descriptor status flag is set and both offset and length is a
>   multiple of the physical media sector size.
>

Hey, this is great stuff.  It wish we could have talked about it a bit
before it was commited.. Most of ffs_rawread.c is fairly generic.  Do you
think you could make a vfs_direct.c or similar and move the generic bits
in there?  It looks like you could keep the ffs specific bits to a minimum
and then leave the rest as helper functions.

Do you have an application that is using this immediately?

Cheers,
Jeff


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030327025926.K64602-100000>