Date: Tue, 18 Aug 2009 14:49:14 -0700 From: Pyun YongHyeon <pyunyh@gmail.com> To: Xin LI <delphij@delphij.net> Cc: Barney Cordoba <barney_cordoba@yahoo.com>, David Christensen <davidch@broadcom.com>, "d@delphij.net" <d@delphij.net>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, Jack Vogel <jfvogel@gmail.com>, Jack F Vogel <jfv@freebsd.org>, yongari@freebsd.org, Julian Elischer <julian@elischer.org> Subject: Re: [PATCH] Fix for e1000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of NOARP flag] Message-ID: <20090818214914.GC15025@michelle.cdnetworks.com> In-Reply-To: <4A8B1729.8070503@delphij.net> References: <5D267A3F22FD854F8F48B3D2B523819339EC3813D2@IRVEXCHCCR01.corp.ad.broadcom.com> <692150.91493.qm@web63906.mail.re1.yahoo.com> <2a41acea0908060905n69edf1dfkbf993d9f8a4edf37@mail.gmail.com> <4A8B1729.8070503@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 18, 2009 at 02:03:37PM -0700, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, Jack, > > I have looked into the code history and found that sys/dev/em/if_em.c,v > 1.119 has introduced the arp_ifinit() call in order to fix the problem > that if_em won't send ARP when IP address is changed. > > I think we can further improve it as attached, say, only do it when > IFF_NOARP is not set. This should have no effect for usual > configuration but fix the problem when NOARP is the desired behavior. > That change was introduced by me. I guess the root cause of the problem was long initialization time of hardware which in turn resulted in unbearable boot time when multiple-alias addresses are assigned to em(4). I don't remember details,though. Since we're in the release cycle, the change you suggested would be quick fix for 8.0. I think em(4)/igb(4) should remove SIOCSIFADDR handling in driver which is layering violation.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090818214914.GC15025>