Date: Mon, 3 Aug 2015 10:29:15 +0200 From: Torsten Zuehlsdorff <info@toco-domains.de> To: Steve Wills <swills@FreeBSD.org> Cc: ruby@freebsd.org Subject: Re: [Gitlab] Current Status of the port Message-ID: <55BF265B.9090401@toco-domains.de> In-Reply-To: <20150731174219.GD49801@mouf.net> References: <55BA3B55.5010000@toco-domains.de> <20150730152241.GC82229@mouf.net> <55BA4532.40107@toco-domains.de> <20150731135045.GA49801@mouf.net> <55BB8272.3060900@toco-domains.de> <20150731143935.GC49801@mouf.net> <55BB8B17.7050509@toco-domains.de> <20150731174219.GD49801@mouf.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello,
>> # cd /usr/ports/devel/rubygem-gitlab_git-rails41
>> # portlint -AC
>> FATAL: Makefile: the last line of a slave port's Makefile has to be
>> .include "${MASTERDIR}/Makefile"
>> FATAL: Makefile: extra item "MASTERDIR" placed in the PORTNAME section.
>> FATAL: Makefile: extra item "PKGNAMESUFFIX" placed in the LICENSE section.
>> WARN: Consider to set DEVELOPER=yes in /etc/make.conf
>> 3 fatal errors and 1 warning found.
>
> portlint doesn't really fully grok slave ports, unless I'm mistaken, so use
> your judgement here, but the include does need to be last.
Okay, will fix.
>> When including the Master-Makefile in the last line, the PKGNAMESUFFIX
>> for example is not used.
>
> Change the master port to use ?= instead of = for the things you want to override.
This works, but increases the number of changed ports ;)
Also it just remove one FATAL error. This other 2 persists. Is this
enough or should i do further research?
Greetings,
Torsten
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55BF265B.9090401>