Date: Wed, 4 Nov 2020 10:31:50 -0500 From: Ed Maste <emaste@freebsd.org> To: Kristof Provost <kp@freebsd.org> Cc: Gordon Bergling <gbe@freebsd.org>, Mateusz Piotrowski <0mp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r367321 - head/sys/amd64/linux Message-ID: <CAPyFy2CRwmeCcmHD_tQLYRsX0NAFbgQiBJMuDaZbCSXWZH7W2w@mail.gmail.com> In-Reply-To: <BABF4769-6634-468C-BD00-D4169334C194@FreeBSD.org> References: <202011041038.0A4AcPNn082013@repo.freebsd.org> <20201104104515.GA83813@lion.0xfce3.net> <BABF4769-6634-468C-BD00-D4169334C194@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 4 Nov 2020 at 07:10, Kristof Provost <kp@freebsd.org> wrote: > > > And why you just abandoned the differential [1]? > > > Probably because it timed out. The review had been pending since August. > Arguably the differential link should have been included as well, but > it=E2=80=99s hardly important in this case. I don=E2=80=99t think we have= explicit > policies about this. We probably should. Yes, it's still worth including the phab URL so that it closes automatically and so that others can see how long it was open for. I take no issue with the change itself.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CRwmeCcmHD_tQLYRsX0NAFbgQiBJMuDaZbCSXWZH7W2w>