Date: Sun, 14 Dec 2003 14:35:13 +0300 (MSK) From: Maxim Konovalov <maxim@macomnet.ru> To: Nate Grey <NateBSD@yahoo.it> Cc: net@FreeBSD.org Subject: Re: Fwd: 5.2-RC + ipfw Message-ID: <20031214143434.J94122@news1.macomnet.ru> In-Reply-To: <200312141223.01385.NateBSD@yahoo.it> References: <200312131149.44582.NateBSD@yahoo.it> <20031213214424.E42015@news1.macomnet.ru> <200312141223.01385.NateBSD@yahoo.it>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 14 Dec 2003, 12:23-0000, Nate Grey wrote:
> On Saturday 13 December 2003 18:47, Maxim Konovalov wrote:
> > Please try an enclosed patch or put a whitespace right after the '('
> > before '\'.
> >
> > Index: ipfw2.c
> > ===================================================================
> > RCS file: /home/ncvs/src/sbin/ipfw/ipfw2.c,v
> > retrieving revision 1.42
> > diff -u -r1.42 ipfw2.c
> > --- ipfw2.c 31 Oct 2003 18:31:55 -0000 1.42
> > +++ ipfw2.c 13 Dec 2003 18:42:18 -0000
> > @@ -2901,15 +2901,14 @@
> > goto done;
> >
> > #define OR_START(target) \
> > - if (ac && (*av[0] == '(' || *av[0] == '{')) { \
> > + if (ac && ( \
> > + !strncmp(*av, "(", strlen(*av)) || \
> > + !strncmp(*av, "{", strlen(*av)) )) { \
> > if (open_par) \
> > errx(EX_USAGE, "nested \"(\" not allowed\n"); \
> > prev = NULL; \
> > open_par = 1; \
> > - if ( (av[0])[1] == '\0') { \
> > - ac--; av++; \
> > - } else \
> > - (*av)++; \
> > + ac--; av++; \
> > } \
> > target: \
> >
> > %%%
>
> Problem solved just adding a whitespace. Should I apply the patch anyway?
Please do if you can. Thanks.
--
Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031214143434.J94122>