Date: Tue, 28 Nov 2006 19:07:29 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: "Greg 'groggy' Lehey" <grog@FreeBSD.org> Cc: Yar Tikhiy <yar@comp.chem.msu.su>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Florent Thoumie <flz@FreeBSD.org>, cvs-src@FreeBSD.org Subject: Re: Style strangenesses (was: cvs commit: src/etc rc.subr) Message-ID: <20061128160729.GA761@rambler-co.ru> In-Reply-To: <20061127223644.GV42090@wantadilla.lemis.com> References: <200611261903.kAQJ3KPp013911@repoman.freebsd.org> <20061127130323.GC77085@comp.chem.msu.su> <20061127223644.GV42090@wantadilla.lemis.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Nov 28, 2006 at 09:06:44AM +1030, Greg 'groggy' Lehey wrote: > On Monday, 27 November 2006 at 16:03:24 +0300, Yar Tikhiy wrote: > > By the way, now the output follows the NetBSD rc.conf style: > > > > # $foo_enable > > foo_enable=YES > > > > Could it be changed even further to match our own rc.conf style? > > I.e.: > > > > # $foo_enable > > foo_enable="YES" > > Can somebody justify this style to me? It seems unnecessarily > confusing, like Microsoft mail headers with > > To: "'Fred Bloggs'" <fred@nowhere.com> > > I'm left with the feeling of sloppiness. > Quotes are needed if a value has spaces. Quotes around values without spaces aren't necessary but nice for uniformity. That said, I don't normally use quotes in /boot/loader.conf. Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFbF7BqRfpzJluFF4RAvLlAJ0b4vJK1cUy+8jSJj6PR9p1+ILvSwCgg7fb SpSZ+eIRmm+Pclx2CBxH8vc= =NRZ7 -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061128160729.GA761>