Date: Tue, 19 Feb 2008 18:10:53 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: sam@FreeBSD.org Cc: perforce@FreeBSD.org Subject: Re: PERFORCE change 135760 for review Message-ID: <20080219.181053.824013453.imp@bsdimp.com> In-Reply-To: <200802192338.m1JNcKvG037641@repoman.freebsd.org> References: <200802192338.m1JNcKvG037641@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Suppress the aggressive inline of gcc; there is no obvious benefit to doing it and the downsides are significant. Once I can nagivate the maze of twisty #ifdefs in cdefs.h I'll add __noinline where it belongs. Maybe the following is sufficient? Index: cdefs.h =================================================================== RCS file: /cache/ncvs/src/sys/sys/cdefs.h,v retrieving revision 1.94 diff -u -r1.94 cdefs.h --- cdefs.h 9 Dec 2007 21:00:36 -0000 1.94 +++ cdefs.h 20 Feb 2008 01:09:57 -0000 @@ -241,6 +241,12 @@ #define __gnu89_inline #endif +#if __GNUC_PREREQ__(3, 1) +#define __noinline __attribute__((__noinline__)) +#else +#define __noinline +#endif + #if __GNUC_PREREQ__(3, 3) #define __nonnull(x) __attribute__((__nonnull__(x))) #else
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080219.181053.824013453.imp>