Date: Wed, 26 May 2010 13:49:09 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Andriy Gapon <avg@icyb.net.ua> Cc: freebsd-fs@FreeBSD.org Subject: Re: ZFS panic: wrong length 131072 for sectorsize 2352 Message-ID: <20100526114909.GC3339@garage.freebsd.pl> In-Reply-To: <4BFD02DC.1050203@icyb.net.ua> References: <4BFA9AEC.1070608@jrv.org> <4BFB884A.3010804@jrv.org> <20100525192721.GE1659@garage.freebsd.pl> <4BFD02DC.1050203@icyb.net.ua>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, May 26, 2010 at 02:15:40PM +0300, Andriy Gapon wrote: > on 25/05/2010 22:27 Pawel Jakub Dawidek said the following: > > On Tue, May 25, 2010 at 03:20:26AM -0500, James R. Van Artsdalen wrote: > >> On 5/24/2010 10:27 AM, James R. Van Artsdalen wrote: > >>> panic: wrong length 131072 for sectorsize 2352 > >> This fixes the bug. > > > > I don't think so:) size should be properly calculated at this point and > > should be multiple of sectorsize. The problem is that vdev_geom_io() > > splits request into MAXPHYS chunks if it is too big, which is wrong, > > because MAXPHYS doesn't have to be multiple of sectorsize. > > But do we really want to support here sector sizes that are not power of two? We can easly support them, so why not? -- Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkv9CrUACgkQForvXbEpPzQECQCcCGYQjHZ57QX5YEptEbbuom39 lf8Amwb9CelZEwMkx/1OP3bc9w2zRyp1 =IDm0 -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100526114909.GC3339>