Date: Mon, 26 Nov 2001 21:42:32 +0000 From: Mark Murray <mark@grondar.za> To: Dag-Erling Smorgrav <des@ofug.org> Cc: audit@freebsd.org, markm@freebsd.org Subject: Re: PAM module patch for review Message-ID: <200111262142.fAQLgWF01871@grimreaper.grondar.org> In-Reply-To: <xzpbshp8osh.fsf@flood.ping.uio.no> ; from Dag-Erling Smorgrav <des@ofug.org> "26 Nov 2001 17:44:46 %2B0100." References: <xzpbshp8osh.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
> Attached. Not as much as I'd like - I did absolutely zip on PAM last
> week - but better than nothing, and I'll try to pick up the pace a
> bit.
>
> Summary of changes:
>
> - Dummy facilities as previously discussed; they all return
> PAM_IGNORE, which is possibly wrong for at least some of them, but
> I'll take a closer look at each of them and tweak them later as I
> gain more experience with PAM.
Ok - good first srat, but I'm not keen to see this committed until
all of the effects are at least understood. I'll read documentation
and play so i can contruibute here.
> - New pam_self(8) module with man page.
Cool! :-)
> - New pam_ssh(8) man page.
Cool^2!
> - Ndditions to the pam_unix(8) man page.
Cool^3!
> - Some minor style(9) fixes.
I personally disagree with
- }
- else {
+ } else {
as these get too caught up in other diffs.
stuff {
:
}
else {
:
}
Separates the blocks out better.
The others don't seem too bad.
> I'm going to continue cleaning up the module man pages and tweak the
> dummy facilities a bit.
Yes please!
M
--
o Mark Murray
\_ FreeBSD Services Limited
O.\_ Warning: this .sig is umop ap!sdn
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111262142.fAQLgWF01871>