Date: Mon, 27 Oct 2008 18:47:01 +0100 From: Hartmut Brandt <hartmut.brandt@dlr.de> To: Diomidis Spinellis <dds@aueb.gr> Cc: Harti Brandt <harti@FreeBSD.ORG>, Andriy Gapon <avg@icyb.net.ua>, current@FreeBSD.ORG Subject: Re: cp(1) and mmap Message-ID: <4905FE95.9030405@dlr.de> In-Reply-To: <4905DD47.7040107@aueb.gr> References: <20080528110003.Q24259@beagle.kn.op.dlr.de> <483D5DF8.4020504@icyb.net.ua> <483F1559.2020600@aueb.gr> <4905DD47.7040107@aueb.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
Diomidis Spinellis wrote: > Diomidis Spinellis wrote: >> Andriy Gapon wrote: >>> on 28/05/2008 12:02 Harti Brandt said the following: >>>> Hi all, >>>> >>>> it looks like there is no fallback in cp(1) when mmaping the source >>>> file >>>> fails. I'm mounting SMB shares via smbnetfs (which in turn uses fuse) >>>> and it seems not to support mmaping files. Shouldn't cp just >>>> fallback to >>>> a normal read()/write() loop in this case? >>> >>> I would think that it should. >>> This topic was brought up several times, but no resolution so far. >>> I think that I've even seen patches. >>> >> >> I've not seen the patches, but the fix is trivial (see the attached >> patch). If there are no objections, I can commit it. > > Fix committed in 184342. Sorry for the long delay. > No problem. Thanks. I had this still in my inbox and was several times about to commit it, but was distracted each time. Thanks, this helps alot. harti > - dds >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4905FE95.9030405>