Date: Thu, 25 Sep 2008 15:39:58 -0500 From: Anthony Liguori <anthony@codemonkey.ws> To: Juergen Lock <nox@jelal.kn-bremen.de>, qemu-devel@nongnu.org, freebsd-emulation@freebsd.org Subject: Re: [Qemu-devel] [PATCH] preprocessor issue in qemu/patch-block-raw-posix.c Message-ID: <48DBF71E.1000405@codemonkey.ws> In-Reply-To: <20080925201703.GA12142@saturn.kn-bremen.de> References: <20080921204025.GA81055@saturn.kn-bremen.de> <200809242210.m8OMAcSZ021572@saturn.kn-bremen.de> <20080925201703.GA12142@saturn.kn-bremen.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Juergen Lock wrote:
> I forgot to note that this also needed the following patch:
>
Why? This #ifdef is working around a very specific bug.
Regards,
Anthony Liguori
> Index: qemu/block-raw-posix.c
> @@ -545,7 +545,8 @@
>
> qemu_aio_set_fd_handler(s->fd, posix_aio_read, NULL, posix_aio_flush, s);
>
> -#if defined(__linux__) && defined(__GLIBC_PREREQ) && !__GLIBC_PREREQ(2, 4)
> +#if defined(__linux__) && defined(__GLIBC_PREREQ)
> +#if !__GLIBC_PREREQ(2, 4)
> {
> /* XXX: aio thread exit seems to hang on RedHat 9 and this init
> seems to fix the problem. */
> @@ -557,6 +558,7 @@
> aio_init(&ai);
> }
> #endif
> +#endif
> posix_aio_state = s;
>
> return 0;
>
> Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
>
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48DBF71E.1000405>