Date: Mon, 10 Aug 2015 16:30:31 -0700 From: Xin Li <delphij@delphij.net> To: Ed Schouten <ed@nuxi.nl>, Xin LI <delphij@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286601 - head/usr.bin/patch Message-ID: <55C93417.80008@delphij.net> In-Reply-To: <CABh_MKmhBC%2BKqn6Xxwe4Q7C_pkUkN9Fn__MLqfQ_O-0ie=%2BPEA@mail.gmail.com> References: <201508102131.t7ALVo5J050735@repo.freebsd.org> <CABh_MKmhBC%2BKqn6Xxwe4Q7C_pkUkN9Fn__MLqfQ_O-0ie=%2BPEA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 08/10/15 14:42, Ed Schouten wrote:
> Hi Xin,
>
> Something I forgot to mention in my previous email:
>
> 2015-08-10 23:31 GMT+02:00 Xin LI <delphij@freebsd.org>:
>> + argp[0] = strdup(RCSDIFF);
>> + argp[1] = strdup(filename);
>
>> + argp[0] = strdup(CHECKOUT);
>> + argp[1] = strdup("-l");
>> + argp[2] = strdup(filename);
>
> While we're at it, should we also add "--" before the filename, or can
> we be sure in this context that they don't start with a dash?
We can't be sure.
However, neither co nor rcsdiff supports "--", so it won't make a
difference.
Cheers,
--
Xin LI <delphij@delphij.net> https://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1.6 (FreeBSD)
iQIcBAEBCgAGBQJVyTQXAAoJEJW2GBstM+ns1LsP/28+tIsZfUJvrk+55a/sHjbc
vUwe+FvFVDnlykjnF9Yk6k7ONZdPTUzhx90EU/63+daxTspi61vk2PA6RbjKoD2b
IKT3DSUskUKOcUqkFMFMTuPwI5VykgbxzQ9dVL6dG1x3fMjFnN/oxBRqBb4hN/Ro
ykbH6hHQds/8blh/ELDUrzHkaWOKEcuk2Ws9pkZH3RX4TM0gO/JI7LloxSINm8BQ
udL2q6n55vUDo3qHlFU87w+CyEwRZ7s6x/5XoqFrlq+6tb7iIA73XKgOwooMBBRU
v3YV2yqNsh3bEbGhAtco0dno3TR1qyMC2CL5UhVKv98TCLPzfzbeLXr+KyCccbv1
Gc/LWCzT7MEai+ZM3mKUnnTBVNvCjW2AfWDieyTbgdas3W6XxoOdvk3eaXpCpf6d
W5wndZ4B/s9u0d6YjlcjHIz89yhuFcVplZaG4zdq7HbEyf2w9UIO9bNyCqM4Z/FI
6/EaNOwC3QHPa7L3V7WBLL0RSfklX9EBELoNj227wEQuXFQh7Wy/pmklXIuXvyMi
QD//EZwKxGaa4mdG/x5dOc25kP8Yz+ARLkL9fhFYBmxyTQMrVr5ucOH4limPfxne
+YYhSTPJRmmD+vUvvSlWWHJLs9FI6iNYpzSi4IHkTysfs7JFzjNAZdhJIBLL344G
CHKEpyPNq6L5XLbf6L/E
=m/95
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55C93417.80008>