Date: Tue, 08 Dec 2009 16:36:27 +0200 From: Alexander Motin <mav@FreeBSD.org> To: src-committers@freebsd.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r200121 - head/sys/dev/ata Message-ID: <4B1E646B.8050209@FreeBSD.org> In-Reply-To: <20091207174233.GG1688@garage.freebsd.pl> References: <200912051340.nB5DepkE089078@svn.freebsd.org> <20091207174233.GG1688@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Pawel Jakub Dawidek wrote: > On Sat, Dec 05, 2009 at 01:40:51PM +0000, Alexander Motin wrote: >> Author: mav >> Date: Sat Dec 5 13:40:51 2009 >> New Revision: 200121 >> URL: http://svn.freebsd.org/changeset/base/200121 >> >> Log: >> Do not ignore device interrupt if bus mastering is still active. It is >> normal in case of media read error and some ATAPI cases, when transfer size >> is unknown beforehand. PCI ATA BM specification tells that in case of such >> underrun driver should just manually stop DMA engine. DMA engine should >> same time guarantie that all bus mastering transfers completed at the moment >> of driver reads interrupt flag asserted. >> This change should fix interrupt storms and command timeouts in many cases. >> >> PR: kern/103602, sparc64/121539, kern/133122, kern/139654 > > I've a box where I see interrupt storm on. This is 8-STABLE with this > patch applied. Pawel found that it was not ATA issue, but USB. Fixed. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B1E646B.8050209>