Date: Tue, 2 Oct 2007 14:51:48 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: db <db@nipsi.de> Cc: freebsd-fs@freebsd.org, Dag-Erling Sm??rgrav <des@des.no> Subject: Re: zpool does not work Message-ID: <20071002125148.GI1693@garage.freebsd.pl> In-Reply-To: <4700E97A.1040704@nipsi.de> References: <4700A791.6020606@encephalon.de> <20071001091106.GB35764@garage.freebsd.pl> <4700BC65.1000303@encephalon.de> <4700BE80.5080109@encephalon.de> <4700C441.30100@nipsi.de> <861wcf82p3.fsf@ds4.des.no> <4700E97A.1040704@nipsi.de>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Oct 01, 2007 at 02:35:06PM +0200, db wrote: > Dag-Erling Sm??rgrav schrieb: > >db <db@nipsi.de> writes: > > > >>We reported this months ago... :-( > >> > >>http://www.freebsd.org/cgi/query-pr.cgi?pr=104389&cat= > >> > >>could someone please verify and commit this fix? > >> > > > >Both patches in the PR are incorrect. The second patch is better than > >the first, but still gets the logic wrong and completely misses the > >point of using an sbuf in the first place. > > > >DES > > > I meant this one > http://www.freebsd.org/cgi/query-pr.cgi?prp=104389-3-diff I fully agree that this should be fixed, but you should use sbuf() directly instead of sprintf()s. Could you another patch with this fixed? It will also eliminate direct memory allocation. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHAj7kForvXbEpPzQRAv/MAJwJ7b6Y5x92t1kwJC1VsoPAE5JqigCeMo5K gIx1Ye6aHLewM5oRNWHQBrY= =UZ2k -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071002125148.GI1693>