Date: Mon, 22 Mar 2004 18:06:48 -0800 (PST) From: Nate Lawson <nate@root.org> To: "David E. O'Brien" <obrien@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_bus.c Message-ID: <20040322180452.A35931@root.org> In-Reply-To: <20040322223625.430EF16A4F2@hub.freebsd.org> References: <20040322223625.430EF16A4F2@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 22 Mar 2004, David E. O'Brien wrote:
> Modified files:
> sys/kern subr_bus.c
> Log:
> Rather than display which interrupts are MPSAFE, display those that aren't.
> This way we can take stock of the work to be done. boot -v will note those
> interrupts that are MPSAFE.
>
> Revision Changes Path
> 1.141 +3 -1 src/sys/kern/subr_bus.c
>
>
> Index: src/sys/kern/subr_bus.c
> diff -u src/sys/kern/subr_bus.c:1.140 src/sys/kern/subr_bus.c:1.141
> --- src/sys/kern/subr_bus.c:1.140 Tue Feb 24 11:31:30 2004
> +++ src/sys/kern/subr_bus.c Mon Mar 22 14:36:11 2004
> @@ -2148,7 +2148,9 @@
> error = BUS_SETUP_INTR(dev->parent, dev, r, flags,
> handler, arg, cookiep);
> if (error == 0) {
> - if (flags & INTR_MPSAFE)
> + if (!(flags & INTR_MPSAFE))
> + device_printf(dev, "[NOT!MPSAFE]\n");
> + if (bootverbose && flags & INTR_MPSAFE)
> device_printf(dev, "[MPSAFE]\n");
> if (flags & INTR_FAST)
> device_printf(dev, "[FAST]\n");
I recommend you parenthesize (flags & INTR_MPSAFE).
-Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040322180452.A35931>