Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Aug 2003 14:44:18 -0700 (PDT)
From:      Marcel Moolenaar <marcel@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 37195 for review
Message-ID:  <200308292144.h7TLiISG060219@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=37195

Change 37195 by marcel@marcel_nfs on 2003/08/29 14:44:17

	Even though we have a 4-byte wide memory I/O resource,
	accessable registers of the z8530 have offsets:
		Channel B control	0
		Channel B data		2
		Channel A control	4
		Channel A data		6
	
	We're accessing bus space outside our assigned range.
	For now, give each port 4 bytes of bus space even though
	it's technically speaking invalid. Something is going on
	with sbus and I don't know yet what it is...

Affected files ...

.. //depot/projects/uart/dev/puc/puc_sbus.c#2 edit

Differences ...

==== //depot/projects/uart/dev/puc/puc_sbus.c#2 (text+ko) ====

@@ -68,7 +68,7 @@
 	for (i = 0; i < 2; i++) {
 		dd.ports[i].type = PUC_PORT_TYPE_UART | PUC_PORT_UART_Z8530;
 		dd.ports[i].bar = 0;
-		dd.ports[i].offset = 0x2 * i;
+		dd.ports[i].offset = 4 * i;
 		dd.ports[i].serialfreq = 0;
 		dd.ports[i].flags = PUC_FLAGS_MEMORY;
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200308292144.h7TLiISG060219>