Date: Wed, 18 Feb 2009 06:52:00 +0800 From: Li-Wen Hsu <lwhsu@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: freebsd-multimedia@freebsd.org, Oliver Heesakkers <dev2@heesakkers.info>, Angelo Turetta <aturetta@commit.it> Subject: Re: gpac-libgpac needs libglut now Message-ID: <20090217225200.GA43498@FreeBSD.cs.nctu.edu.tw> In-Reply-To: <200902171401.28939.jkim@FreeBSD.org> References: <200902161313.59518.dev2@heesakkers.info> <4999CE0E.8050000@commit.it> <86bpt12dwb.fsf@pluton.xbsd.name> <200902171401.28939.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks, I am looking into this issue there days, but currently I just
don't know why I cannot reproduce this error, and testing in the
tinderbox just works fine. I'll commit the patch if others test this
OK.
On Tue, Feb 17, 2009 at 14:01:19 -0500, Jung-uk Kim wrote:
> On Tuesday 17 February 2009 12:04 pm, Denise H. G. wrote:
> > Angelo Turetta <aturetta@commit.it> writes:
> > > Oliver Heesakkers wrote:
> > >> Hello,
> > >>
> > >> I was unable to build gpac-libgpac because I did not have
> > >> libglut installed. Perhaps you need to add a dependency here.
> > >
> > > That's not enough.
> > >
> > > In my PC I have libGL, libGL, libglut installed, but the build
> > > stops at:
> > >
> > > cc -O3 -O2 -fno-strict-aliasing -pipe -fPIC -pthread
> > > -fno-strict-aliasing -Wno-pointer-sign
> > > -I/space/usr/ports/multimedia/gpac-libgpac/work/gpac/include
> > > -I../ -DGPAC_HAVE_CONFIG_H -fPIC -DPIC -c compositor/mesh.c -o
> > > compositor/mesh.opic
> > > In file included from compositor/mesh.c:33:
> > > compositor/gl_inc.h:45:19: error: GL/gl.h: No such file or
> > > directory
> > >
> > > The problem seems that this part of src/Makefile apparently is
> > > not used:
> > >
> > > # OpenGL support
> > > ifeq ($(HAS_OPENGL),yes)
> > > EXTRALIBS+= $(OGL_LIBS)
> > > COMPOSITOR_CFLAGS+=$(OGL_INCLS)
> > > endif
> > >
> > > config.mak contains:
> > > OGL_INCLS=-I/usr/local/include
> > > OGL_LIBS=-L/usr/local/lib -lGL -lglut
> > >
> > > I hope someone who better understand gmake can
> > > Angelo.
> >
> > I don't know much about gmake, but made a dirty hack and it seemed
> > to work...
> >
> > ---- cut ----
>
> Can you try the attached patch instead?
>
> Thanks,
>
> Jung-uk Kim
> Index: multimedia/gpac-libgpac/Makefile
> ===================================================================
> RCS file: /home/pcvs/ports/multimedia/gpac-libgpac/Makefile,v
> retrieving revision 1.15
> diff -u -r1.15 Makefile
> --- multimedia/gpac-libgpac/Makefile 14 Feb 2009 01:55:45 -0000 1.15
> +++ multimedia/gpac-libgpac/Makefile 17 Feb 2009 18:53:42 -0000
> @@ -26,7 +26,7 @@
> INSTALL_WRKSRC= ${WRKSRC}/bin/gcc
> LIBVER= 1
>
> -CONFIGURE_ARGS= --cc="${CC}" \
> +CONFIGURE_ARGS= --cc="${CC}" --X11-path="${X11BASE}" \
> --extra-cflags="${CFLAGS} ${PTHREAD_CFLAGS} -fPIC" \
> --extra-ldflags="${LDFLAGS} ${PTHREAD_LIBS}"
>
> Index: multimedia/gpac-libgpac/files/patch-configure
> ===================================================================
> RCS file: multimedia/gpac-libgpac/files/patch-configure
> diff -N multimedia/gpac-libgpac/files/patch-configure
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ multimedia/gpac-libgpac/files/patch-configure 17 Feb 2009 18:53:42 -0000
> @@ -0,0 +1,44 @@
> +--- configure.orig 2008-12-02 13:04:42.000000000 -0500
> ++++ configure 2009-02-17 13:34:33.000000000 -0500
> +@@ -33,6 +33,7 @@
> + make="make"
> + strip="strip"
> + cpu=`uname -m`
> ++targetos=`uname -s`
> + debuginfo="no"
> + sdl_path=""
> + sdl_local="no"
> +@@ -222,10 +223,12 @@
> + if [ x"$canon_arch" = x"x86_64" -o x"$canon_arch" = x"amd64" ]; then
> + if [ -z "`echo $CFLAGS | grep -- -m32`" ]; then
> + cpu="x86_64"
> +- libdir="lib64"
> +- #that's a bit crude...
> +- PIC_CFLAGS="-fPIC -DPIC"
> +- want_pic="yes"
> ++ if [ x"$targetos" != x"FreeBSD" ]; then
> ++ libdir="lib64"
> ++ #that's a bit crude...
> ++ PIC_CFLAGS="-fPIC -DPIC"
> ++ want_pic="yes"
> ++ fi
> + fi
> + fi
> + ;;
> +@@ -280,7 +283,6 @@
> + source_path="`cd \"$source_path\"; pwd`"
> + fi
> + # OS specific
> +-targetos=`uname -s`
> + case $targetos in
> + BeOS)
> + js_flags=-DXP_BEOS
> +@@ -1673,7 +1675,7 @@
> + echo "USE_X11_XV=$has_x11_xv" >> config.mak
> + fi
> +
> +-if test "$is_64" = "yes"; then
> ++if test "$is_64" = "yes" -a "$freebsd" = "no" ; then
> + echo "X11_LIB_PATH=$X11_PATH/lib64" >> config.mak
> + else
> + echo "X11_LIB_PATH=$X11_PATH/lib" >> config.mak
--
Li-Wen Hsu <lwhsu AT FreeBSD.org>
http://lwhsu.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090217225200.GA43498>