Date: Mon, 25 Aug 2014 13:35:21 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Benjamin Kaduk <bjkfbsd@gmail.com>, Gleb Smirnoff <glebius@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, peter@wemm.org, Don Lewis <truckman@freebsd.org>, Rui Paulo <rpaulo@felyko.com>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org> Subject: Re: svn commit: r270510 - head Message-ID: <53FB81E9.1010407@FreeBSD.org> In-Reply-To: <CAJ5_RoBMwpoph617iSrgj2%2BxGyFm_R3Az21v-UB_53_mnKdaZA@mail.gmail.com> References: <61DA1EC8-C938-4AB8-B518-7249307B4379@felyko.com> <201408242301.s7ON1N51056169@gw.catspoiler.org> <20140825141048.GQ7693@FreeBSD.org> <CAJ5_RoBMwpoph617iSrgj2%2BxGyFm_R3Az21v-UB_53_mnKdaZA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --L7kQGKhOEMDDAGalw2X8OiWWnm268lSFa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/25/2014 12:36 PM, Benjamin Kaduk wrote: > On Mon, Aug 25, 2014 at 10:10 AM, Gleb Smirnoff <glebius@freebsd.org > <mailto:glebius@freebsd.org>> wrote: >=20 >=20 > And carrying this stuff costs us almost nothing. >=20 >=20 > The cost of having it in the tree is small, yes. But the runtime cost > when people actually run delete-old will only keep increasing ... it > already feels kind of slow, to me. >=20 > -Ben=20 This could be fixed by not calling rm(1) for every file but instead using xargs rm so it is called only a few times, when not needing -i. The same goes for the chflags and -f/-L tests. It would be much more manageable if all of the logic moved into a shell script. --=20 Regards, Bryan Drewery --L7kQGKhOEMDDAGalw2X8OiWWnm268lSFa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJT+4HpAAoJEDXXcbtuRpfPlVYH+wRnVhqwbCu7OMvkwPDSOi+o 6YrO/gX7Dnutnpci1xe4D5XLwOTzDqmWoxXHPfbD0WwgFZQkKgP2vpMOJ+5EIrJ8 gMKooR3uXzUnPRNzGFUrSBLZfTUlRix9EMCuADUcVCGTP9LiqEikZ5FAopQJuND4 yKcNJ7ljqbgxtNk38JNYTfjy2eed4ET1u3c8h9xo4NKsHAzWW8F0SRR+wn8UV1Mk PRQZ0JANIctJ6rTMqTn9kgm4UONPApkqQ81wDn5Q28CNCzY18VhOm9myanVeCRLo 1FCqYdLotpU18Tl5ba3u9m1K50vVKQMjmr7aTDHcHn3k9aemqJL9VxbEmbtQMuM= =eH5l -----END PGP SIGNATURE----- --L7kQGKhOEMDDAGalw2X8OiWWnm268lSFa--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53FB81E9.1010407>