Date: Sat, 28 Jul 2018 21:59:58 -0600 From: Brad Davis <brd@FreeBSD.org> To: Mark Millard <marklmi@yahoo.com>, svn-src-head@freebsd.org Subject: Re: svn commit: r336744 - in head: sbin/pfctl/tests/files share/mk Message-ID: <1532836798.1025520.1456191920.7D934477@webmail.messagingengine.com> In-Reply-To: <EFD410C3-0F6D-4426-9A12-4C0FD59D4EAA@yahoo.com>
index | next in thread | previous in thread | raw e-mail
On Sat, Jul 28, 2018, at 9:53 PM, Mark Millard wrote:
> Brad Davis brd at FreeBSD.org wrote on
> Thu Jul 26 17:11:15 UTC 2018 :
>
> > On Thu, Jul 26, 2018, at 11:09 AM, Shawn Webb wrote:
> > . . .
> > > > -FILES= ${.CURDIR}/pf????.in
> > > > -FILES+= ${.CURDIR}/pf????.include
> > > > -FILES+= ${.CURDIR}/pf????.ok
> > > > +FILES!= echo ${.CURDIR}/pf????.in ${.CURDIR}/pf????.include ${.CURDIR}/pf????.ok
> > >
> > > Should this use ${ECHO} instead of echo?
> >
> >
> > No, that wouldn't work at all with the !=.
>
> /usr/ports/Mk/bsd.port.mk has things like:
>
> OPSYS!= ${UNAME} -s
> and:
> _OSRELEASE!= ${UNAME} -r
>
> Is your ${ECHO} note specific to the combination of ${ECHO} and !=
> for some reason --or does it apply to the likes of ${UNAME} mixed
> with != too?
That is different.. due to share/mk/sys.mk has:
.if empty(.MAKEFLAGS:M-s)
ECHO ?= echo
ECHODIR ?= echo
.else
ECHO ?= true
.if ${.MAKEFLAGS:M-s} == "-s"
ECHODIR ?= echo
.else
ECHODIR ?= true
.endif
.endif
Which means if someone is using make -s, these tests would not install.. which is probably not what is desired and there are better ways to do that.
Regards,
Brad Davis
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1532836798.1025520.1456191920.7D934477>