Date: Sat, 28 Feb 1998 17:34:31 -0800 From: Mike Smith <mike@smith.net.au> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.ORG, msmith@FreeBSD.ORG Subject: Re: cvs commit: src/sys/gnu/ext2fs ext2_vnops.c Message-ID: <199803010134.RAA06838@dingo.cdrom.com> In-Reply-To: Your message of "Sun, 01 Mar 1998 12:11:26 %2B1100." <199803010111.MAA22984@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
> > Modified files: > > sys/gnu/ext2fs ext2_vnops.c > > Log: > > Add local stup putpages/getpages routines. > > Submitted by: Terry Lambert <terry@freebsd.org> > > I think putpages/getpages should go in default_vnodeop_entries[] like > dima suggested. > > Anyway, the patch was not suitable for committing verbatim, because it > has many style bugs, starting with disordering of lists recently sorted > by phk. Aside from the issue of parenthesised arguments to return, what other style violations are you aware of? I see no 'recent sorting' activity by phk in the affected file, nor any clear ordering to the only thing in the file that could reasonably be described as a list. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199803010134.RAA06838>